Skip to content

v1.17.3 - V1/V2 Codebase Separation Cleanup (2025-12-15)

What Changed?

This release completes the v1/v2 codebase separation by removing v2 code that was mistakenly included in v1 files. The v1 detection buffer now contains only v1-specific logic, improving code clarity and maintainability. No user-facing changesβ€”this is a pure refactoring for internal code organization.


What's New

Refactoring: V1/V2 Codebase Separation

What it does: Removes v2-specific code (unified device response protocol) from v1 files. This ensures complete separation between v1 (legacy protocol) and v2 (unified protocol) code paths.

Why it matters:

  • Improves code clarity: v1 files now contain only v1 logic
  • Reduces confusion: No mixed v1/v2 code in the same file
  • Simplifies maintenance: Each codebase is now truly independent
  • Enables faster evolution: v1 and v2 can evolve without affecting each other

Files changed:

  • src/v1_detection_buffer.cpp: Removed v2 code path (50 lines deleted)

Installation

Quick Start

# Get the release
git checkout v1.17.3

# Build
task build

# Upload
task upload

# Check it works
task monitor

What's Different from the Last Version?

βœ… Added

  • None (refactoring release)

πŸ”§ Changed

  • Removed v2 protocol code from v1_detection_buffer.cpp
  • Simplified detection_buffer_send() function (v1 only, 50 lines removed)
  • No changes to v1 detection buffer behavior or output format

πŸ› Fixed

  • Fixed v1/v2 codebase mixing in detection buffer module

Is It Safe to Upgrade?

Backward Compatible: Yes

  • No changes to v1 detection buffer API or output format
  • All v1 builds (release, dev, wifi) unaffected
  • Pure refactoring with zero user-facing changes
  • Safe to upgrade for all v1 users

Tests Passed

  • βœ… All v1 builds compile without errors (task build, task dev:build)
  • βœ… All pre-commit hooks passed (trailing whitespace, file endings, merge conflicts)
  • βœ… No changes to detection buffer output format
  • βœ… No linker errors (v2 includes properly guarded)

Release Details

  • Date: 2025-12-15
  • Version: v1.17.3
  • Files Changed: 1 (src/v1_detection_buffer.cpp)
  • Lines Removed: 50 (v2 code)
  • Build Type: Refactoring (no new features)

Next Steps

  • Continue v1/v2 separation cleanup (identify remaining mixed code)
  • Consider renaming device_response_builder.h to v2_device_response_builder.h for consistency
  • Monitor v2 implementation (v2_event_queue.cpp, v2_detection_processor.cpp) for similar cleanup opportunities